CodeIssuesPull Requests

fix: move conductor.json to repo root for proper detection #88184

Mergedwyattjoh wants to merge into canary from fix/conductor-config-location
ConversationCommitsFiles changed
wyattjohcommented 2 months agoowner

What?

Moves conductor.json from .conductor/conductor.json to the repository root and updates script paths accordingly.

Why?

Conductor searches for configuration files in a specific priority order:

  1. Workspace root
  2. Remote default branch
  3. Repository root

The previous location at .conductor/conductor.json wasn't in the standard search path, which could cause Conductor to not detect the configuration properly. Moving to the repo root follows the .

How?

  • Moved conductor.json to repository root
  • Updated script paths from ./scripts/ to ./.conductor/scripts/
  • Scripts remain in .conductor/scripts/ for organization
fix: move conductor.json to repo root for proper detection173c97f
nextjs-botaddedcreated-by: Next.js team2 months ago
wyattjohmerged commit aa9c7162 months ago
wyattjohclosed this2 months ago
nextjs-botcommented 2 months agocollaborator

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

MetricCanaryPRChange
Cold (Listen)455ms455ms✓
Cold (First Request)1.174s1.162s✓
Warm (Listen)456ms457ms✓
Warm (First Request)339ms348ms✓
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

MetricCanaryPRChange
Cold (Listen)455ms455ms✓
Cold (First Request)1.827s1.811s✓
Warm (Listen)456ms456ms✓
Warm (First Request)1.831s1.823s✓

⚡ Production Builds

MetricCanaryPRChange
Fresh Build4.131s4.165s✓
Cached Build4.108s4.136s✓
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

MetricCanaryPRChangeTrend
Fresh Build13.902s13.884s✓
Cached Build14.091s14.086s✓
node_modules Size457 MB457 MB✓▁████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ⚠️ +10 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
CanaryPRChange
middleware-b..fest.js gzip787 B791 B✓
Total787 B791 B⚠️ +4 B
Build Details
Build Manifests
CanaryPRChange
_buildManifest.js gzip447 B452 B🔴 +5 B (+1%)
Total447 B452 B⚠️ +5 B

📦 Webpack

Client

Main Bundles
CanaryPRChange
2086.HASH.js gzip169 BN/A-
2161-HASH.js gzip5.4 kBN/A-
2747-HASH.js gzip4.48 kBN/A-
4322-HASH.js gzip52.5 kBN/A-
ec793fe8-HASH.js gzip62.3 kBN/A-
framework-HASH.js gzip59.8 kB59.8 kB✓
main-app-HASH.js gzip250 B254 B🔴 +4 B (+2%)
main-HASH.js gzip38.4 kB38.8 kB✓
webpack-HASH.js gzip1.68 kB1.69 kB✓
1596.HASH.js gzipN/A169 B-
2658-HASH.js gzipN/A52.2 kB-
6349-HASH.js gzipN/A4.46 kB-
7019-HASH.js gzipN/A5.42 kB-
b17a3386-HASH.js gzipN/A62.3 kB-
Total225 kB225 kB⚠️ +126 B
Polyfills
CanaryPRChange
polyfills-HASH.js gzip39.4 kB39.4 kB✓
Total39.4 kB39.4 kB✓
Pages
CanaryPRChange
_app-HASH.js gzip194 B193 B✓
_error-HASH.js gzip182 B182 B✓
css-HASH.js gzip336 B335 B✓
dynamic-HASH.js gzip1.8 kB1.8 kB✓
edge-ssr-HASH.js gzip256 B256 B✓
head-HASH.js gzip352 B349 B✓
hooks-HASH.js gzip385 B384 B✓
image-HASH.js gzip580 B580 B✓
index-HASH.js gzip259 B258 B✓
link-HASH.js gzip2.5 kB2.51 kB✓
routerDirect..HASH.js gzip319 B317 B✓
script-HASH.js gzip385 B387 B✓
withRouter-HASH.js gzip316 B315 B✓
1afbb74e6ecf..834.css gzip106 B106 B✓
Total7.97 kB7.96 kB✅ -8 B

Server

Edge SSR
CanaryPRChange
edge-ssr.js gzip124 kB124 kB✓
page.js gzip239 kB239 kB✓
Total363 kB364 kB⚠️ +663 B
Middleware
CanaryPRChange
middleware-b..fest.js gzip653 B656 B✓
middleware-r..fest.js gzip155 B156 B✓
middleware.js gzip32.9 kB33 kB✓
edge-runtime..pack.js gzip846 B846 B✓
Total34.5 kB34.6 kB⚠️ +61 B
Build Details
Build Manifests
CanaryPRChange
_buildManifest.js gzip738 B738 B✓
Total738 B738 B✓
Build Cache
CanaryPRChange
0.pack gzip3.62 MB3.62 MB🔴 +2.09 kB (+0%)
index.pack gzip99.2 kB100 kB✓
index.pack.old gzip98.3 kB99 kB✓
Total3.82 MB3.82 MB⚠️ +3.79 kB

🔄 Shared (bundler-independent)

Runtimes
CanaryPRChange
app-page-exp...dev.js gzip302 kB302 kB✓
app-page-exp..prod.js gzip157 kB157 kB✓
app-page-tur...dev.js gzip302 kB302 kB✓
app-page-tur..prod.js gzip157 kB157 kB✓
app-page-tur...dev.js gzip299 kB299 kB✓
app-page-tur..prod.js gzip155 kB155 kB✓
app-page.run...dev.js gzip299 kB299 kB✓
app-page.run..prod.js gzip155 kB155 kB✓
app-route-ex...dev.js gzip68.7 kB68.7 kB✓
app-route-ex..prod.js gzip47.5 kB47.5 kB✓
app-route-tu...dev.js gzip68.7 kB68.7 kB✓
app-route-tu..prod.js gzip47.5 kB47.5 kB✓
app-route-tu...dev.js gzip68.3 kB68.3 kB✓
app-route-tu..prod.js gzip47.3 kB47.3 kB✓
app-route.ru...dev.js gzip68.3 kB68.3 kB✓
app-route.ru..prod.js gzip47.3 kB47.3 kB✓
dist_client_...dev.js gzip324 B324 B✓
dist_client_...dev.js gzip326 B326 B✓
dist_client_...dev.js gzip318 B318 B✓
dist_client_...dev.js gzip317 B317 B✓
pages-api-tu...dev.js gzip41.1 kB41.1 kB✓
pages-api-tu..prod.js gzip31.2 kB31.2 kB✓
pages-api.ru...dev.js gzip41 kB41 kB✓
pages-api.ru..prod.js gzip31.2 kB31.2 kB✓
pages-turbo....dev.js gzip50.8 kB50.8 kB✓
pages-turbo...prod.js gzip38.2 kB38.2 kB✓
pages.runtim...dev.js gzip50.7 kB50.7 kB✓
pages.runtim..prod.js gzip38.2 kB38.2 kB✓
server.runti..prod.js gzip60 kB60 kB✓
Total2.68 MB2.68 MB⚠️ +1 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api-tu..ntime.dev.js
  • pages-turbo...ntime.dev.js
View diffs
pages-api-tu..ntime.dev.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

github-actions[bot]addedlocked1 month ago
github-actions[bot]locked this conversation as resolved1 month ago

Labels

created-by: Next.js teamlocked

Changes

+2-21 file

Participants

Back to pull requests